Fix #4060 by showing second line of commit#4251
Merged
techknowlogick merged 2 commits intogo-gitea:masterfrom Jun 15, 2018
Merged
Fix #4060 by showing second line of commit#4251techknowlogick merged 2 commits intogo-gitea:masterfrom
techknowlogick merged 2 commits intogo-gitea:masterfrom
Conversation
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Codecov Report
@@ Coverage Diff @@
## master #4251 +/- ##
=======================================
Coverage 19.97% 19.97%
=======================================
Files 153 153
Lines 30524 30524
=======================================
Hits 6097 6097
Misses 23513 23513
Partials 914 914Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
Member
|
LGTM |
bkcsoft
added
lgtm/need 1
techknowlogick
approved these changes
Jun 15, 2018
bkcsoft
added
lgtm/done
Member
|
@JonasFranzDEV please create backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4060
strings.TrimSpaceactually removes the\nat the end of the commit message. Because of that the comparison must be changed.